Fix an entry statement debuginfo bug #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanpkc
reviewed
Sep 18, 2023
|
Please also reword the commit message. It should start with a commit title, with a topic prefix, and separated from the commit message body with a blank line. For example: |
When the compiler generates debuginfo for a procedure, it does not consider that if is an ENTRY statement, the number of arguments will increase by one. We can fix this problem by using the new number of arguments as returned by the process_ll_abi_func_ftn_mod function.
Liuyunlong0336
force-pushed
the
Fix-an-entry-debuginfo-bug
branch
from
cd537fe
to
bd2d4ba
Compare
bryanpkc
reviewed
Nov 1, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
@pawosm-arm @shivaramaarao gentle ping |
pawosm-arm
reviewed
Nov 7, 2023
pawosm-arm
approved these changes
Nov 9, 2023
shivaramaarao
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the compiler generates debuginfo, it does not consider that when there is an entry, the number of arguments will increase by one.
We can fix this problem by getting the returned information by process_ll_abi_func_ftn_mod function, and using the new number of arguments.