Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the dataset preprocessing #5

Merged
merged 7 commits into from
Nov 30, 2024

Conversation

plonerma
Copy link
Collaborator

@plonerma plonerma commented Nov 13, 2024

We discussed improving how the dataset is preprocessed. I added an test-case to ensure the original dataset is not being changed (but instead a changed copy is returned) and started improving some minor points.

There are some open points that should be addressed in the future:

  • The DataCleaner should be EITHER stateless (i.e. is configured in the init and preprocessing dataset does not change any attributes) OR statefull (i.e. it should only be invoke once with a dataset).
  • We need to change the order of the processing steps, as at the moment string-labels do not work.

@plonerma plonerma requested a review from lukasgarbas November 13, 2024 16:44
Copy link
Collaborator

@lukasgarbas lukasgarbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some refactoring. Datacleaner doesn't change its instance attributes or the original dataset. prepare_dataset(dataset) now returns texts, labels, and the task category.

Changed the order of data preprocessing steps. String labels are now converted to integers when creating the label map.

@lukasgarbas lukasgarbas marked this pull request as ready for review November 30, 2024 03:30
@lukasgarbas lukasgarbas merged commit 1b416b3 into main Nov 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants