fix T5 tokenizer loading #3544
Merged
fix T5 tokenizer loading #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Yes, this indeed fixes the problem. I was able to load the best model from the set of models trained. Hoping that this could be merged into the master branch as soon as possible. Thanks, @helpmefindaname! |
|
@helpmefindaname thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3543
The T5 tokenizer fast is required to load from the slow tokenizer when
add_prefix_spaceis True. See the codeI am not sure why exactly this is implemented that way, as the traces do not show a specific reasoning, but with a small exception on our side, we can easily support all T5 tokenizers.