Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Fixed versions of black and ruff in CI #3422

Closed
stefan-it opened this issue Mar 11, 2024 · 2 comments · Fixed by #3423
Closed

[Feature]: Fixed versions of black and ruff in CI #3422

stefan-it opened this issue Mar 11, 2024 · 2 comments · Fixed by #3423
Labels
feature A new feature

Comments

@stefan-it
Copy link
Member

stefan-it commented Mar 11, 2024

Problem statement

Hi everyone,

I was using latest black and ruff locally and it changed some files that I definitely not touched/changes.

Then I could also see test failures of my two recent PRs.

Maybe we should pin a specific version of both black and ruff to avoid this in future.

Before a new release of Flair we could just use the latest versions of them, perform tree-wide reformating and then update the pinned versions again.

What do you think?

@stefan-it stefan-it added the feature A new feature label Mar 11, 2024
@alanakbik
Copy link
Collaborator

Yes, pinning the version makes sense!

@stefan-it
Copy link
Member Author

I installed Flair in fresh new virtual environment and used the versions for black and pytest-ruff after installing all dependencies from requirements.txt and requirements-dev.txt.

Tree-wide re-formatting is also applied and result can be seen in #3423. This should us give a green CI hopefully soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants