-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating a doc page with autodocs and everything #3273
Conversation
253a0d7
to
87ad76e
Compare
f718433
to
66a26c3
Compare
66a26c3
to
3ddc564
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good - thanks a lot for making all these changes and improving the documentation across the board!
I am not able to run sphinx-multiversion docs doc_build
locally - it is giving me a "No package metadata was found for flair" unless I also install flair in the virtual environment. But then I get a "outputdir 'doc-page' for refs/remotes/origin/doc-page conflicts with other versions" error. Maybe you can walk me through it?
I also not the deploy action is not working. Aside from these things, I would say it is ready to merge and see in action!
|
||
## Setup | ||
|
||
Flair requires python-3.7 or higher. To make sure our code also runs on the oldest supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.8 very soon, we need to remember that this info needs to be changed here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is fixed
@@ -30,11 +30,12 @@ | |||
|
|||
|
|||
def set_proxies(proxies: typing.Dict[str, str]) -> None: | |||
"""Allows for data downloaded from urls to be forwarded to a proxy. | |||
r"""Allows for data downloaded from urls to be forwarded to a proxy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the "r" do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the r prefix makes a string to a raw string
meaning, that it doesn't use escape sequences etc.
for example r"\n" == "\\n"
evaluates to a backslash followed by an n, while "\n"
would evaluate to the enter symbol
Thanks a lot @helpmefindaname! This is really helpful and a big step towards improving our documentation! |
Building a doc page to contain more than just the tutorials.
flair.datasets
vsflair.datasets.sequence_labeling
, ...)landing page designed to our wishes@alanakbik will do this in a separate MR later.The docs can be checkout locally and tested anytime by following the
updating_documentation.md
contributers guide. You know you have successfully built the docs, if you can watch the guide again in html format ;-)