Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for translated field names #6

Open
gstvg opened this issue Dec 10, 2019 · 5 comments
Open

Support for translated field names #6

gstvg opened this issue Dec 10, 2019 · 5 comments

Comments

@gstvg
Copy link

gstvg commented Dec 10, 2019

Does this component support translated labels? I'm using it with a translated admin but on dialog selection field names are not translated.

@AkselsLedins
Copy link
Collaborator

Hello @gstvg ,

No, but this behavior should be easy to add. Please feel free to submit a PR.

https://github.com/fizix-io/ra-customizable-datagrid/blob/master/src/CustomizableDatagrid.js#L46

add withTranslate HOC: https://github.com/marmelab/react-admin/blob/master/docs/Translation.md#withtranslate-hoc and use label: translate(...

@gstvg
Copy link
Author

gstvg commented Jan 28, 2020

#5 fix this

@gstvg
Copy link
Author

gstvg commented Feb 3, 2020

@AkselsLedins

@hardingmatt
Copy link

Hello @AkselsLedins ,

It looks like #5 fixes this issue. When you have a chance, could you please review and merge that Pull Request?

Thank you!

@hardingmatt
Copy link

Hi @AkselsLedins ,

It would be extremely helpful to have this fixed. Could you please take a look at this one-line fix, when you have a chance? Thank you!

https://github.com/fizix-io/ra-customizable-datagrid/pull/5/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants