Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] No jobs table in NS2 schema but package trying import #29

Open
1 of 4 tasks
ghost opened this issue Feb 7, 2023 · 4 comments
Open
1 of 4 tasks

[FEATURE] No jobs table in NS2 schema but package trying import #29

ghost opened this issue Feb 7, 2023 · 4 comments
Assignees
Labels
status:scoping Currently being scoped type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@ghost
Copy link

ghost commented Feb 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

the package is trying to import a table that does not exist in NS2 schema [JOB]

Relevant error log or model output

Database Error in model stg_netsuite2__jobs_tmp
JOB does not exist or not authorized

Expected behavior

No error

dbt Project configurations

Now is "enabled = false" to avoid error

Package versions

0.7.0

What database are you using dbt with?

snowflake

dbt Version

1.3.2

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@ghost ghost added the bug Something isn't working label Feb 7, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz removed the bug Something isn't working label Feb 7, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @ropalloni thanks for opening this issue. From my understanding it looks like you are not using the jobs component within Netsuite2. Is that correct?

If so, this may be an easy update to simply add a variable to disable these models if you do not have the jobs component (similar to how you are enabled: false configuring them for the time being). They also currently do not flow downstream to the transform package so it shouldn't impact any downstream transformations if they are not being leveraged.

Ideally we would include these models within the disable sources section of our README. Are there any other sources that you are currently not using which our package assumes you to have?

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement status:scoping Currently being scoped update_type:feature Primary focus is to add new functionality labels Feb 7, 2023
@ghost
Copy link
Author

ghost commented Feb 10, 2023

Ok thanks. I followed your suggestion thanks. No trouble with other sources.

However, I'm actually having trouble with the (old, NS1) transaction_tax_details table. Apparently it is not in the new NS2 schema. Anyway somehow they should figure out how to link lines and taxes properly since taxes are lines as well.

image

image

This is the mapping transaction_tax_details did in NS1
image

Any hint on this?

@fivetran-jamie fivetran-jamie mentioned this issue Feb 14, 2023
14 tasks
@fivetran-jamie
Copy link
Contributor

hey @ropalloni , as for your second question, i think tax details and transaction lines are linked if you have the SuiteTax feature enabled https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_4283867856.html (which we don't have internally)

@ghost
Copy link
Author

ghost commented Feb 22, 2023

hi @fivetran-jamie, thanks for this. Very helpful.
One last question. Is there any macro in the package to handle the shift of STATUS values from NS1 and NS2.
Apparently SuiteQL provides you an internal function to solve the status, see here https://timdietrich.me/blog/netsuite-suiteql-transaction-statuses/

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title [Bug] No jobs table in NS2 schema but package trying import [FEATURE] No jobs table in NS2 schema but package trying import Feb 22, 2023
@fivetran-jamie fivetran-jamie self-assigned this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:scoping Currently being scoped type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

No branches or pull requests

2 participants