-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display attribution #17
Comments
Thanks for the heads-up, will look into it. It's probably best that giphy_picker addresses this. Question: where do I find this requirement of proper author attribution per Dec 1st? |
Here is the email I received from them explaining everything https://mailchi.mp/0762226d308c/important-updates-for-your-giphy-integration |
Yes this is important if you want to use the plugin in a production environment, otherwise you're limited to their development API only which only allows a small number of GIFs for testing purposes. They also require their logo to be displayed saying 'Powered by GIPHY' - say at the bottom of the search screen. From their terms of service: https://support.giphy.com/hc/en-us/articles/360028134111-GIPHY-API-Terms-of-Service- 'You must label your application with “Powered by Giphy” and the Giphy logo..' and 'You agree to properly attribute all pieces of content that you obtain through the API and at no time will you falsely attribute any such content. For the avoidance of doubt, this means that you won’t display any content in your applications without Giphy user and/or source attribution where available.' I'm keen to use this plugin in a production environment so if it could be added in giphy_picker natively that would be awesome. To obtain a Production API with proper usage limits you need to upload a video of the app with the above attributions etc. |
A GiphyOverlay widget is already included which renders a 'Powered by GIPHY' overlay image over its content. This widget is used when previewing gif selections and can be used in your application as well. This should cover the Powered by Giphy requirement. I'm not sure how to implement the user/source attribution. |
Ah I see, yes you're right thanks! For source attribution I'll implement this independently from the widget for the moment 👌 |
If it helps anyone else I've gotten production approval from GIPHY with the following changes:
This may be overkill but the guidelines are quite vague - this at least is enough to get a production API key. Photos attached: My hacky changes can be found in my public repo: |
Any updates on this? |
Can't you add a PR for this? Essential stuff really. |
I have now added a attribution mark that can toggled on and off and should support dark mode to, Examples below go as follow: iOS -> Android -> iOS with the parameter attributionMarkDarkMode = true (This does not change the canvas color, the canvas colors follow your theme, it only changes the image) This can be user even if the search bar and preview are removed. I have gotten production approval with this solution and made a pull request. Or you can use the solition from my github |
Hi,
Giphy will require starting on december 1st that all gifs assign proper attribution to the author. Is there an update planned for this plugin to display it in the GiphyImage class or do we have implement it ourselves by making a request to the api to get the author's name?
Thanks
The text was updated successfully, but these errors were encountered: