Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display attribution #17

Open
tchavet opened this issue Nov 11, 2020 · 10 comments
Open

Display attribution #17

tchavet opened this issue Nov 11, 2020 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tchavet
Copy link

tchavet commented Nov 11, 2020

Hi,
Giphy will require starting on december 1st that all gifs assign proper attribution to the author. Is there an update planned for this plugin to display it in the GiphyImage class or do we have implement it ourselves by making a request to the api to get the author's name?
Thanks

@kozw
Copy link
Contributor

kozw commented Nov 11, 2020

Thanks for the heads-up, will look into it. It's probably best that giphy_picker addresses this.

Question: where do I find this requirement of proper author attribution per Dec 1st?

@tchavet
Copy link
Author

tchavet commented Nov 22, 2020

Here is the email I received from them explaining everything https://mailchi.mp/0762226d308c/important-updates-for-your-giphy-integration

@aidangill-projects
Copy link

aidangill-projects commented Jan 4, 2021

Yes this is important if you want to use the plugin in a production environment, otherwise you're limited to their development API only which only allows a small number of GIFs for testing purposes.

They also require their logo to be displayed saying 'Powered by GIPHY' - say at the bottom of the search screen.

From their terms of service:

https://support.giphy.com/hc/en-us/articles/360028134111-GIPHY-API-Terms-of-Service-

'You must label your application with “Powered by Giphy” and the Giphy logo..'

and

'You agree to properly attribute all pieces of content that you obtain through the API and at no time will you falsely attribute any such content. For the avoidance of doubt, this means that you won’t display any content in your applications without Giphy user and/or source attribution where available.'

I'm keen to use this plugin in a production environment so if it could be added in giphy_picker natively that would be awesome.

To obtain a Production API with proper usage limits you need to upload a video of the app with the above attributions etc.

@kozw
Copy link
Contributor

kozw commented Jan 5, 2021

A GiphyOverlay widget is already included which renders a 'Powered by GIPHY' overlay image over its content. This widget is used when previewing gif selections and can be used in your application as well. This should cover the Powered by Giphy requirement.

Screenshot 2021-01-05 at 14 08 30

I'm not sure how to implement the user/source attribution.

@kozw kozw added enhancement New feature or request help wanted Extra attention is needed labels Jan 5, 2021
@aidangill-projects
Copy link

Ah I see, yes you're right thanks! For source attribution I'll implement this independently from the widget for the moment 👌

@aidangill-projects
Copy link

aidangill-projects commented Jan 14, 2021

If it helps anyone else I've gotten production approval from GIPHY with the following changes:

  1. Adding the powered by GIPHY logo on the search and preview screens
  2. Putting a powered by GIPHY and a clickable attribution link next to the GIF when shown (if it exists), which I save in the database encoded along with URL, which is all provided by the gif object, no API interaction required

This may be overkill but the guidelines are quite vague - this at least is enough to get a production API key.

Photos attached:

giphy_1
giphy_2
giphy_3

My hacky changes can be found in my public repo:

https://github.com/aidangill-projects

@zaidkazi
Copy link

zaidkazi commented Apr 5, 2021

Any updates on this?

@Bolling88
Copy link

Bolling88 commented Aug 27, 2021

If it helps anyone else I've gotten production approval from GIPHY with the following changes:

  1. Adding the powered by GIPHY logo on the search and preview screens
  2. Putting a powered by GIPHY and a clickable attribution link next to the GIF when shown (if it exists), which I save in the database encoded along with URL, which is all provided by the gif object, no API interaction required

This may be overkill but the guidelines are quite vague - this at least is enough to get a production API key.

My hacky changes can be found in my public repo:

https://github.com/aidangill-projects

Can't you add a PR for this? Essential stuff really.

@sohaibnoman
Copy link

sohaibnoman commented Sep 25, 2021

drawing

This is how Signal does it, a solution similar to this one would work even you don't have a preview or appbar!

@sohaibnoman
Copy link

sohaibnoman commented Sep 26, 2021

I have now added a attribution mark that can toggled on and off and should support dark mode to, Examples below go as follow: iOS -> Android -> iOS with the parameter attributionMarkDarkMode = true (This does not change the canvas color, the canvas colors follow your theme, it only changes the image)

drawing

drawing

drawing

This can be user even if the search bar and preview are removed. I have gotten production approval with this solution and made a pull request. Or you can use the solition from my github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants