Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with frame rates 30-60 #30

Open
seabasss opened this issue Jul 30, 2020 · 1 comment
Open

Error with frame rates 30-60 #30

seabasss opened this issue Jul 30, 2020 · 1 comment

Comments

@seabasss
Copy link

Hey!

Thanks for a great library!

If I'm not incorrect I think this part:
/^(?:[0-1][0-9]|2[0-3])(:|;)(?:[0-5][0-9])\1(?:[0-5][0-9])(:|;)(?:[0-2][0-9])$/.test(timecode);
should be changed to:
/^(?:[0-1][0-9]|2[0-3])(:|;)(?:[0-5][0-9])\1(?:[0-5][0-9])(:|;)(?:[0-5][0-9])$/.test(timecode);
to support frame rates from 30 and over.

Or make that value dynamic based on frame rate to be even more precise.

Thanks again!

@seabasss
Copy link
Author

seabasss commented Dec 3, 2020

Any ideas? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant