Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.3.0] Chrome Logger support issues #51

Open
tminich opened this issue Nov 14, 2019 · 0 comments
Open

[v1.3.0] Chrome Logger support issues #51

tminich opened this issue Nov 14, 2019 · 0 comments

Comments

@tminich
Copy link

tminich commented Nov 14, 2019

Chrome Logger support seems to have some issues/shortcomings right now.

  1. Maybe I'm misunderstanding what it does, but the 'Render X-ChromeLogger-Data response headers to the console.' setting doesn't seem to do anything, the extension behaves the same no matter if it is turned on or off. Chrome Logger data appears in the FirePHP tab but not in the console (like the FF Chrome Logger extension shows it).
    The way I read it it's supposed to work like the Chrome Logger extension does. If that is the case, it's broken right now.
    On a side note I'd appreciate a setting to simply turn of Chrome Logger support entirely, but it's not really a high priority for me.

  2. This is a specific issue with the current version of the server side Library (ChromePhp). FirePHP does not render the source code line the Log entry was issued from. It works in the Chrome Logger extension and it also works if I use the Chrome Logger handler of Monolog server side.

The Differences (in the X-ChromeLogger-Data header) are:

ChromePhp Monolog
Version 4.1.0 4.0
Columns log, backtrace, type label, log, backtrace, type
(doesn't work) (works)

I took a brief look at the source code and from my limited understanding it should actually work, but it doesn't.

  1. 'table'-type entries are rendered very effectively (in a show-the-info-in-one-glance way) by Chrome Logger in contrast to FirePHP (this kinda effects logging tables via the FirePHP protocol as well)

Let's take this array as an example:

[
  ['name' => 'Fred', 'country' => 'USA'],
  ['name' => 'Thomas', 'country' => 'Germany'],
]

Logged via ::table rendered in the console via Chrome Logger it looks like this:
chrome_logger

In FirePHP I need to click 1 + (number of rows) times to get this:
firephp

Yes, the second is more accurate in representing the structure of the data, but usually you know what the structure is if you log a variable, you need to know the information contained and, in my opinion, the first is much more effective at displaying that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant