Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC incorrect warning #3609

Closed
ripatel-fd opened this issue Dec 4, 2024 · 1 comment
Closed

GCC incorrect warning #3609

ripatel-fd opened this issue Dec 4, 2024 · 1 comment

Comments

@ripatel-fd
Copy link
Contributor

Incorrect stringop-overflow check breaks build on some GCC versions.
Release blocker

In function 'fd_quic_key_update_complete',
    inlined from 'fd_quic_handle_v1_one_rtt' at src/waltz/quic/fd_quic.c:2126:5:
src/waltz/quic/fd_quic.c:2043:3: error: 'fd_quic_key_update_derive' accessing 88 bytes in a region of size 16 [-Werror=stringop-overflow=]
 2043 |   fd_quic_key_update_derive( &conn->secrets, conn->new_keys );
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@ripatel-fd
Copy link
Contributor Author

Fixed in #3753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant