Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The FIRUser displayName appears empty when using 'Sign in with Apple' #1168

Open
mark-osypenko opened this issue Oct 6, 2023 · 1 comment

Comments

@mark-osypenko
Copy link

mark-osypenko commented Oct 6, 2023

  • Objective C or Swift: Swift
  • iOS version: 17.0.2
  • Firebase SDK version: 10.15.0
  • FirebaseUI version: 13.1.0

The library does not utilize the complete name provided by Apple. Instead, it constructs a FIROAuthCredential using only the token and rawNonce.

Steps to reproduce:

  1. Sign in with Apple

Observed Results:

FIRUser displayName is empty

Relevant Code:

need to replace in FUIOAuth.m line 371

FIROAuthCredential *credential = [FIROAuthProvider credentialWithProviderID:@"apple.com" IDToken:idToken rawNonce:rawNonce];

with

FIROAuthCredential *credential = [FIROAuthProvider appleCredentialWithIDToken:idToken rawNonce:rawNonce, fullName: appleIDCredential.fullName];

@kostapostolakis
Copy link

Do you have an estimation about when we will have the fix in this issue?

@mark-osypenko mark-osypenko closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
@mark-osypenko mark-osypenko reopened this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants