CSS improvements of Angular frontend #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DovOps
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Is there a reason you did not want to use one of the existing icons in that directory?
e.g.: /main/web-front-end/angular/main/assets/img/traderx-icon.png, or the apple-touch icon? Not that it's such a big deal, but figured I'd ask.
There was a problem hiding this comment.
We need to render it on dark background, so we chose the white version of the icon (and no text)
|
Thanks @TheJuanAndOnly99 - looks much better now! @DovOps - I believe we're ready to pass it to marketing, maybe for some low touch social, plus newsletter and "this week at finos"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addresses issue #125.
Screenshot below of changes:
