Correct API declaration of GetResult to be nullable (#110)

finos · Feb 8, 2024 · 5081c26 · 5081c26
1 parent ea60fbb
commit 5081c26
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Fdc3/IIntentResolution.cs b/src/Fdc3/IIntentResolution.cs
@@ -36,6 +36,6 @@ public interface IIntentResolution
         /// </summary>
         string? Version { get; }
 
-        Task<IIntentResult> GetResult();
+        Task<IIntentResult?> GetResult();
     }
 }
diff --git a/src/Fdc3/IntentResolution.cs b/src/Fdc3/IntentResolution.cs
@@ -44,6 +44,6 @@ public IntentResolution(IAppMetadata source, string intent, string? version = nu
         /// </summary>
         public string? Version { get; }
 
-        public abstract Task<IIntentResult> GetResult();
+        public abstract Task<IIntentResult?> GetResult();
     }
 }
diff --git a/src/Tests/Finos.Fdc3.Tests/IntentResolutionTests.cs b/src/Tests/Finos.Fdc3.Tests/IntentResolutionTests.cs
@@ -55,7 +55,7 @@ public MockIntentResolution(IAppMetadata source, string intent, string? version
         {
         }
 
-        public override Task<IIntentResult> GetResult()
+        public override Task<IIntentResult?> GetResult()
         {
             throw new NotImplementedException();
         }
-Original file line number
+Diff line change
@@ Expand Up @@
             {
             }
-            public override Task<IIntentResult> GetResult()
+            public override Task<IIntentResult?> GetResult()
             {
                 throw new NotImplementedException();
             }
@@ Expand Down @@