Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error_document (and thus origin_path) shouldn't start with a slash #17

Open
forevermatt opened this issue Feb 14, 2022 · 1 comment
Open
Labels
bug Something isn't working

Comments

@forevermatt
Copy link
Collaborator

Hi @fillup 👋

variable "origin_path" {
description = "Path in S3 bucket for hosted files, with leading slash"
type = string
default = "/public"
}

These lines state that origin_path should have a leading slash, but I think the README (which says it shouldn't) is actually correct. Including a leading slash seems to break the error_document feature in S3. For example "public/index.html" works as an error document path, but "/public/index.html" doesn't work, and the origin_path is used in assembling the final error document path.

However, changing that expectation for origin_path might require updates to other code in this module.

@forevermatt forevermatt added the bug Something isn't working label Feb 14, 2022
@fillup
Copy link
Owner

fillup commented Feb 14, 2022

I'm guessing we always overwrote the default path in our configs, so if we're not using it with the preceding slash it's probably fine to update. Could release as a breaking change revision if we want to make sure not to break things on others using it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants