You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
setCustomSettingsForPattern in the patternMaker.ts file needs error handling.
When you have a beat higher than the beatsPerBar
When you have a subBeat higher than the current subdivision -1. The -1 is necessary because [0, 1, 2, 3] would be your options for ['1', 'e', '&', 'a'] with a subdivision of 4.
Add some tests to make sure an error is being thrown.
The text was updated successfully, but these errors were encountered:
Re-opened as I've had to comment this error checking out at the class level.
There is no way to select a fill start beat too high (compared with beats per bar) on the UI, so it is currently safe. But this should be checked on the class level too.
Unfortunately there seems to be some sort of race condition where the error will throw even before the correct beat start is updated.
setCustomSettingsForPattern in the patternMaker.ts file needs error handling.
The -1 is necessary because [0, 1, 2, 3] would be your options for ['1', 'e', '&', 'a'] with a subdivision of 4.
Add some tests to make sure an error is being thrown.
The text was updated successfully, but these errors were encountered: