Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Incorrect gas fees for state reachability analysis #1945

Open
Stebalien opened this issue Dec 7, 2023 · 3 comments
Open

BUG: Incorrect gas fees for state reachability analysis #1945

Stebalien opened this issue Dec 7, 2023 · 3 comments
Assignees
Labels
Kind: Bug Something isn't working

Comments

@Stebalien
Copy link
Member

The ref-fvm is currently using the numbers from the first round of benchmarking (on an i7-1185G laptop). The final benchmarks were re-run on an AMD EPYC 7402P, but the ref-fvm was never updated to reflect this.

We have a two options:

  1. Keep the current numbers, update the FIP.
  2. Fix the gas numbers in the ref-fvm in the next network version.

I kind of want to just update the FIP. We don't need any "security margin" here because that's built into the block time itself (there's more variability in block validation time from tipset size than anything we can do here).

@Stebalien Stebalien added the Kind: Bug Something isn't working label Dec 7, 2023
@Stebalien Stebalien self-assigned this Dec 7, 2023
@maciejwitowski
Copy link
Contributor

@Stebalien I trust your judgement but since these differences are significant (over 2x for some operations), should we give more details on the tradeoff here? Ideally we would be able to show using a few examples the % diff of using old vs new set of numbers and present conclusions like: "In example X of calling a contract function F, this change resulted in a negligible 2% increase of the overall cost".

@Stebalien
Copy link
Member Author

Stebalien commented Dec 7, 2023 via email

@arajasek
Copy link
Contributor

arajasek commented Dec 7, 2023

Meh, I'd say just fix them in FVM master / the next time we have to update the pricelist anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants