Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll on pagination change in list records #14681

Open
wants to merge 4 commits into
base: 3.x
Choose a base branch
from

Conversation

mvenghaus
Copy link
Contributor

By default the scroll position is not affected when changing the page. I've added a method to scroll the wire component into the view.

@danharrin danharrin added the ux label Nov 2, 2024
@danharrin danharrin added this to the v3 milestone Nov 2, 2024
@danharrin
Copy link
Member

Does this scroll the table all the way to the top? Or just make sure that the pagination UI is still visible

Please can you refactor this to not use $this->js(), it's not really a feature I'm really a fan of and we don't use it elsewhere in Filament.

@mvenghaus
Copy link
Contributor Author

Does this scroll the table all the way to the top? Or just make sure that the pagination UI is still visible

Please can you refactor this to not use $this->js(), it's not really a feature I'm really a fan of and we don't use it elsewhere in Filament.

it scrolls up to the table. i changed it to an event instead of using js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this to the Filament\Tables\Concerns\CanPaginateRecords trait, so it applies to all tables (using InteractsWithTables) and not just the list page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants