Fix tests & phpstan

filamentphp · Apr 23, 2024 · dfe9707 · dfe9707
1 parent b9b13cd
commit dfe9707
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 42 deletions.
diff --git a/packages/schema/src/Concerns/HasStateBindingModifiers.php b/packages/schema/src/Concerns/HasStateBindingModifiers.php
@@ -17,6 +17,7 @@ trait HasStateBindingModifiers
 
     protected bool $isLiveOnBlur = false;
 
+    /** @var array<string> */
     protected array $livePartials = [];
 
     /**
@@ -39,12 +40,9 @@ public function reactive(): static
         return $this;
     }
 
-    /**
-     * @param  array<string>  $partials
-     */
-    public function lazy(array $partials = []): static
+    public function lazy(): static
     {
-        $this->live(onBlur: true, partiallyRender: $partials);
+        $this->live(onBlur: true);
 
         return $this;
     }
@@ -168,6 +166,9 @@ public function isLazy(): bool
         return $this->isLiveOnBlur();
     }
 
+    /**
+     * @return array<string>
+     */
     public function getLivePartials(): array
     {
         return $this->livePartials;

diff --git a/packages/support/src/Overrides/OverrideHandleComponents.php b/packages/support/src/Overrides/OverrideHandleComponents.php
diff --git a/packages/support/src/Partials/SupportPartials.php b/packages/support/src/Partials/SupportPartials.php
@@ -13,6 +13,13 @@
 
 class SupportPartials extends ComponentHook
 {
+    public function hydrate(): void
+    {
+        if (! app()->runningUnitTests()) {
+            $this->storeSet('skipRender', fn (): bool => $this->shouldSkipRender());
+        }
+    }
+
     public function call(): Closure
     {
         $this->storeSet('callsCount', ($this->storeGet('callsCount') ?? 0) + 1);
@@ -62,13 +69,13 @@ public function shouldSkipRender(): bool
 
     public function shouldRender(): bool
     {
-        $effects = ($this->storeGet('callsCount') ?? 0) + ($this->storeGet('updatesCount') ?? 0);
+        $effects = intval($this->storeGet('callsCount') ?? 0) + intval($this->storeGet('updatesCount') ?? 0);
 
         if (! $effects) {
             return true;
         }
 
-        $renders = count($this->storeGet('partials') ?? []) + ($this->storeGet('partialSkipsCount') ?? 0);
+        $renders = count($this->storeGet('partials') ?? []) + intval($this->storeGet('partialSkipsCount') ?? 0);
 
         if (! $renders) {
             return true;
@@ -113,18 +120,6 @@ public function shouldRenderMountedActionsOnly(bool $whenActionMounted = true):
         return $this->component->getOriginallyMountedActionIndex() !== $mountedActionIndex;
     }
 
-    protected function renderAndQueuePartials(Closure $getPartialsUsing): void
-    {
-        app(ExtendBlade::class)->startLivewireRendering($this->component);
-
-        $this->partials = [
-            ...$this->partials,
-            ...$getPartialsUsing(),
-        ];
-
-        app(ExtendBlade::class)->endLivewireRendering();
-    }
-
     public function dehydrate(ComponentContext $context): void
     {
         $partials = [];

diff --git a/packages/support/src/SupportServiceProvider.php b/packages/support/src/SupportServiceProvider.php
@@ -94,8 +94,6 @@ class_exists(RequestReceived::class) && Event::listen(RequestReceived::class, fn
                     ->withMaxInputLength(500000),
             ),
         );
-
-        $this->app->bind(HandleComponents::class, OverrideHandleComponents::class);
     }
 
     public function packageBooted(): void