Fix Colocalisation_Test window crash on multiple runs #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctrueden I see you've been involved in a lot of the most recent commits, is this something you could consider merging in? |
|
@pvlaraia Thanks for the ping. I'll try to review and merge it this week. |
ctrueden
changed the title
If a script uses Colocalisation_Test, and closes the result window, subsequent attempts to run Colocalisation_Test will crash because the reference to the window will still be there, but the attempts to write to the window will crash because the window was closed. To verify, revert changes to Colocalisation_Test.java & run the new test case added - the 2nd attempt to run coloc will fail. The solution was to cleanup the window ref when a window is closed. Signed-off-by: Curtis Rueden <[email protected]>
ctrueden
force-pushed
the
fix-window-crash
branch
from
4a835e8
to
087405d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If a script uses Colocalisation_Test, and closes the result window, subsequent attempts to run Colocalisation_Test will crash because the reference to the window will still be there, but the attempts to write to the window will crash because the window was closed. To verify, revert changes to Colocalisation_Test.java & run the new test case added - the 2nd attempt to run coloc in the unit test will fail.
The solution was to cleanup the window ref when a window is closed.