Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] adds filter for deprecationStatus and baseversion #16

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[TASK] adds filter for deprecationStatus and baseversion #16

merged 1 commit into from
Sep 5, 2023

Conversation

maurerle
Copy link
Member

Description

This adds a filter option for deprecationStatus and Base Version (mostly gluon base version, but also Debian/Ubuntu for supernodes)

Motivation and Context

fixes #14
fixes ffrgb/meshviewer#334

How Has This Been Tested?

Screenshots/links (if appropriate):

From FFAC domain:
image

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@maurerle
Copy link
Member Author

@skorpy2009 kannst du bitte die pipeline auf dem main fixen, damit das gemerged werden kann..?

@skorpy2009
Copy link
Member

@maurerle done, please rebase

@maurerle
Copy link
Member Author

@skorpy2009 done, ready to merge.

blocktrron
blocktrron reviewed Aug 22, 2023
View reviewed changes
locale/en.json Outdated Show resolved Hide resolved
@skorpy2009 skorpy2009 requested review from MyIgel and margau August 22, 2023 14:15
@skorpy2009 skorpy2009 requested a review from weeman1337 August 25, 2023 12:44
@maurerle
Copy link
Member Author

maurerle commented Sep 3, 2023

I retested this with a clean config and did not find further issues

@weeman1337 weeman1337 merged commit a904f2c into freifunk:main Sep 5, 2023
@maurerle maurerle mentioned this pull request Dec 17, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blocktrron blocktrron blocktrron approved these changes

@MyIgel MyIgel Awaiting requested review from MyIgel

@margau margau Awaiting requested review from margau

@weeman1337 weeman1337 Awaiting requested review from weeman1337

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gluon Version Filter for deprecated devices
4 participants
@maurerle @skorpy2009 @blocktrron @weeman1337