Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract read::StreamReader to its own crate (or tokio?) #20

Open
abusch opened this issue Oct 24, 2018 · 1 comment
Open

Extract read::StreamReader to its own crate (or tokio?) #20

abusch opened this issue Oct 24, 2018 · 1 comment

Comments

@abusch
Copy link

abusch commented Oct 24, 2018

Hi,

while contributing to the shiplift crate, I ran into the problem of converting a Stream<Item = Chunk> into an AsyncReader so I could use the Framed / Decoder stuff from tokio-codec. After banging my head on it for a few days, I found your StreamReader implementation which works great, but I'd like to avoid copying/pasting it...

Given that it's not specific to ipfs, would you consider extracting it to its own crate, or ideally submitting it to the tokio project?

I'm happy to do some of the work if that helps.

@ferristseng
Copy link
Owner

Hi,

I'm a bit stretched for time right now, but, yes that would be awesome if you could submit it to the tokio project! I have had other people tell me they found that code useful too, so I'm sure it would be helpful to have it in tokio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants