Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexBox layout problems #68

Closed
fennifith opened this issue Jun 27, 2020 · 5 comments
Closed

FlexBox layout problems #68

fennifith opened this issue Jun 27, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@fennifith
Copy link
Owner

It seems that the button "links" occasionally have problems asserting their dimensions within the FlexBox RecyclerView layouts they're contained in...

  • Occasionally, I've opened the about page to find that all of the links have decided to use the smallest width possible, and the button text has wrapped to multiple lines
  • Most of the time a UserDialog is opened, the links recycler will not display a second line of items regardless of whether they have wrapped to another line, even though its height is wrap_content. Possibly related to Support RecyclerView of which height is wrap_content google/flexbox-layout#349.
@fennifith fennifith added the bug Something isn't working label Jun 27, 2020
@hameno
Copy link

hameno commented Jun 28, 2020

Notice this as well:
image
on a Pixel 3a emulator API 29

@hameno
Copy link

hameno commented Jun 28, 2020

Related (?) problem:
image

    <me.jfenn.attribouter.wedges.AppWedge
        description="An Android application designed to help developers by automatically adding their apps to a widget for easy launching / uninstalling / reinstalling etc."
        playStoreUrl="https://play.google.com/store/apps/details?id=de.psdev.devdrawer"
        repo="github:PSDev/DevDrawer" />

Related question: On https://github.com/fennifith/Attribouter/wiki/AppWedge it says, that the play store link should get automatically generated, but I still had to manually enter the url for the button/icon to show.

@fennifith
Copy link
Owner Author

Huh. Yeah, it looks like the AppWedge isn't quite built to work with less than four links. If it's possible for you to, err, find another two, then it might work... lol

Created #70 to track this; not a major amount of work to fix, but I know I'm not gonna get around to it today.

On https://github.com/fennifith/Attribouter/wiki/AppWedge it says, that the play store link should get automatically generated, but I still had to manually enter the url for the button/icon to show.

Yep, the wiki's a bit outdated right now; there were a lot of changes in the last update. I'll go over it all at some point & fix everything, but that's gonna take a while.

@hameno
Copy link

hameno commented Jun 28, 2020

This app is in very early development, those fixes are not urgent. I'll can wait for the updates

@fennifith
Copy link
Owner Author

I seem to have fixed one of these issues by re-using the layout manager across recycled views; this should hopefully fix the squashing issues on the licenses screen.

I'm not sure what has changed since this was created, but I can no longer reproduce the problems in the UserDialog either; perhaps it was another dependency causing those issues which was updated in 08e18e1. If I don't run into any other issues, I'll close this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants