fix: corectly build URLs for github releases

entity/githubrelease.go

@@ -1,6 +1,6 @@
 package entity
 
 type GithubRelease struct {
-	Release  `yaml:",inline"`
 	ExecName string `yaml:"exec-name"`
+	Release  `yaml:",inline"`
 }

provision/provision.go

@@ -153,7 +153,7 @@ func (p Provisioner) ensureReleases() error {
 		return errors.New("empty release directory")
 	}
 
-	return ensureReleases(p.Config.Releases, p.Config.GithubReleases, p.Config.Settings)
+	return ensureReleases(p.Config)
 }
 
 func (p Provisioner) runPreflightTasks() error {

provision/release.go

@@ -736,14 +736,19 @@ func processGithubReleases(githubReleases []entity.GithubRelease) ([]entity.Rele
 			return releases, fmt.Errorf("no ref specified for GitHub release: %+v", githubRelease)
 		}
 
-		refTokens := strings.Split(githubRelease.Ref, "/")
-		if len(refTokens) != 2 {
-			return releases, fmt.Errorf("unexpected release name %s", githubRelease.Ref)
-		}
-		ref := refTokens[1]
-		releaseUrl := fmt.Sprintf("https://github.com/%s/releases/download/%s", githubRelease.Ref,
+		githubRef := githubRelease.Ref
+		releaseUrl := fmt.Sprintf("https://github.com/%s/releases/download/%s", githubRef,
 			githubRelease.Url)
 
+		ref := githubRelease.ExecName
+		if ref == "" {
+			refTokens := strings.Split(githubRef, "/")
+			if len(refTokens) != 2 {
+				return releases, fmt.Errorf("unexpected release name %s", githubRef)
+			}
+			ref = refTokens[1]
+		}
+
 		release := entity.Release{
 			Cleanup:       githubRelease.Cleanup,
 			DontLink:      githubRelease.DontLink,
@@ -766,18 +771,19 @@ func processGithubReleases(githubReleases []entity.GithubRelease) ([]entity.Rele
 	return releases, nil
 }
 
-func ensureReleases(releases []entity.Release, githubReleases []entity.GithubRelease, s settings.Settings) error {
+func ensureReleases(config entity.Config) error {
 	var releaseErrs []error
 
-	processedReleases, err := processGithubReleases(githubReleases)
+	releases := config.Releases
+	processedReleases, err := processGithubReleases(config.GithubReleases)
 	if err == nil {
 		releases = append(releases, processedReleases...)
 	} else {
 		releaseErrs = append(releaseErrs, err)
 	}
 
 	for _, release := range releases {
-		err = ensureRelease(release, s)
+		err = ensureRelease(release, config.Settings)
 		if err != nil {
 			internal.Log.Errorf("Error ensuring release %s: %v", release.Name(), err)
 		}