Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Cannot have code changes in auto_config.cpp - will be overriden #3

Open
AlbertoEAF opened this issue Apr 21, 2022 · 3 comments
Labels
low priority Nice to have but not crucial S effort T-shirt effort weighing: S

Comments

@AlbertoEAF
Copy link
Collaborator

I just found out this file helpers/parameter_generator.py, which states at the beginning:

This script generates LightGBM/src/io/config_auto.cpp file
with list of all parameters, aliases table and other routines
along with parameters description in LightGBM/docs/Parameters.rst file
from the information in LightGBM/include/LightGBM/config.h file.

meaning all the changes in config_auto that are done currently in fairgbm need to be moved out of there to the original LightGBM/include/LightGBM/config.h file.

@AlbertoEAF AlbertoEAF changed the title [bug] The new code is dependent on changes on auto_config.cpp but that will be overriden [refactor] Cannot have code changes in auto_config.cpp - will be overriden Apr 21, 2022
@AndreFCruz
Copy link
Contributor

AndreFCruz commented May 5, 2022

I'll leave here a couple of required changes to the configs:

image

and:

image

@AndreFCruz AndreFCruz added the S effort T-shirt effort weighing: S label Jul 19, 2022
@AndreFCruz
Copy link
Contributor

Update: all code changes have been ported to the config.h file (we still need if there are any errors when parsing/compiling it to the generated config_auto.cpp).

@GoncaloArs GoncaloArs self-assigned this Aug 23, 2022
@GoncaloArs
Copy link
Collaborator

GoncaloArs commented Aug 23, 2022

FairGBM parameters need to be defined in order for this task to be completed.

@GoncaloArs GoncaloArs removed their assignment Aug 23, 2022
@GoncaloArs GoncaloArs added low priority Nice to have but not crucial and removed Important labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Nice to have but not crucial S effort T-shirt effort weighing: S
Projects
None yet
Development

No branches or pull requests

3 participants