Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when passing redisClient and not uri #197

Open
2 tasks done
palmtown opened this issue Mar 2, 2024 · 0 comments
Open
2 tasks done

Error when passing redisClient and not uri #197

palmtown opened this issue Mar 2, 2024 · 0 comments

Comments

@palmtown
Copy link
Contributor

palmtown commented Mar 2, 2024

Steps to reproduce

  • Tell us what broke. The more detailed the better.

If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.

Exhibit 1
app.configure( sync({ redisClient }) );

  • If you can, please create a simple example that reproduces the issue and link to a gist, jsbin, repo, etc.

You can reproduce by configuring feathersjs sync as shown in the Exhibit 1 snipplet above.

Expected behavior

Code should not generate an error when a redisClient object is passed.

Actual behavior

Code throws the error: A uri option with the database connection string, or a redisClient object has to be provided to feathers-sync

I have resolved the issue and created a pull request at: #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant