Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Extend pandas version support #3664

Closed
wants to merge 6 commits into from
Closed

chore: Extend pandas version support #3664

wants to merge 6 commits into from

Conversation

sudohainguyen
Copy link
Collaborator

@sudohainguyen sudohainguyen commented Jun 30, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3709

adchia
adchia approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, sudohainguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudohainguyen
Copy link
Collaborator Author

hi @adchia java integration test failed

@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 11, 2023
@sudohainguyen
Copy link
Collaborator Author

just retriggered the pipelines, please approve again @adchia

@sudohainguyen sudohainguyen mentioned this pull request Aug 13, 2023
Closed
@sudohainguyen sudohainguyen reopened this Aug 13, 2023
@adchia
Copy link
Collaborator

adchia commented Sep 7, 2023

Turns out this was a legitimate error (the tests also showed an issue with the pyarrow version used in the java tests). Fixed it + updated teh requirements.txt files too

@adchia
Copy link
Collaborator

adchia commented Sep 7, 2023

Looks like there's some failing tests from the upgrade

@sudohainguyen sudohainguyen marked this pull request as draft September 23, 2023 09:50
@sudohainguyen
Copy link
Collaborator Author

sudohainguyen commented Sep 23, 2023 •
edited
Loading

https://stackoverflow.com/questions/76389694/transforming-pyspark-to-pandas-dataframe

looks like latest pyspark is not ready yet for pandas 2.0 (will be fixed in pyspark 4.0.0 apache/spark#42920)

we're encountering the same issue with datetime64 dtype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pandas 2.0 support
3 participants
@sudohainguyen @feast-ci-bot @adchia