Skip to content

Commit

Permalink
fix: Fix several type check errors. Upgrade the mypy version.
Browse files Browse the repository at this point in the history
Signed-off-by: Shuchu Han <[email protected]>
  • Loading branch information
shuchu committed Feb 11, 2024
2 parents e412890 + 78bf235 commit 0f5e838
Show file tree
Hide file tree
Showing 13 changed files with 766 additions and 62 deletions.
1 change: 0 additions & 1 deletion sdk/python/feast/importer.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import importlib
from typing import Optional

from feast.errors import (
FeastClassImportError,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/snowflake_source.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import warnings
from typing import Any, Callable, Dict, List, Iterable, Optional, Tuple, no_type_check
from typing import Any, Callable, Dict, Iterable, List, Optional, Tuple, no_type_check

from typeguard import typechecked

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ def _delete_object(
"""
cursor = execute_snowflake_statement(conn, query)

if cursor.rowcount and (cursor.rowcount < 1) and not_found_exception: # type: ignore
if cursor.rowcount and (cursor.rowcount < 1) and not_found_exception: # type: ignore
raise not_found_exception(name, project)
self._set_last_updated_metadata(datetime.utcnow(), project)

Expand Down
4 changes: 0 additions & 4 deletions sdk/python/feast/infra/utils/hbase_utils.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from typing import List, Optional
from typing import List, Optional

from happybase import ConnectionPool

Expand Down Expand Up @@ -42,9 +41,6 @@ def __init__(
pool: Optional[ConnectionPool] = None,
host: Optional[str] = None,
port: Optional[int] = None,
pool: ConnectionPool = None,
host: Optional[str] = None,
port: Optional[int] = None,
connection_pool_size: int = 4,
):
if pool is None:
Expand Down
34 changes: 16 additions & 18 deletions sdk/python/requirements/py3.10-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ black==22.12.0
# via feast (setup.py)
bleach==6.1.0
# via nbconvert
boto3==1.34.37
boto3==1.34.39
# via
# feast (setup.py)
# moto
botocore==1.34.37
botocore==1.34.39
# via
# boto3
# moto
Expand Down Expand Up @@ -139,11 +139,11 @@ cryptography==41.0.7
# snowflake-connector-python
# types-pyopenssl
# types-redis
dask==2024.1.1
dask==2024.2.0
# via feast (setup.py)
db-dtypes==1.2.0
# via google-cloud-bigquery
debugpy==1.8.0
debugpy==1.8.1
# via ipykernel
decorator==5.1.1
# via ipython
Expand Down Expand Up @@ -203,7 +203,7 @@ geojson==2.5.0
# via rockset
geomet==0.2.1.post1
# via cassandra-driver
google-api-core[grpc]==2.16.2
google-api-core[grpc]==2.17.0
# via
# feast (setup.py)
# firebase-admin
Expand All @@ -215,7 +215,7 @@ google-api-core[grpc]==2.16.2
# google-cloud-datastore
# google-cloud-firestore
# google-cloud-storage
google-api-python-client==2.116.0
google-api-python-client==2.117.0
# via firebase-admin
google-auth==2.27.0
# via
Expand Down Expand Up @@ -313,10 +313,8 @@ httplib2==0.22.0
httptools==0.6.1
# via uvicorn
httpx==0.26.0
# via
# feast (setup.py)
# jupyterlab
identify==2.5.33
# via feast (setup.py)
identify==2.5.34
# via pre-commit
idna==3.6
# via
Expand All @@ -342,7 +340,7 @@ ipython==8.21.0
# great-expectations
# ipykernel
# ipywidgets
ipywidgets==8.1.1
ipywidgets==8.1.2
# via great-expectations
isodate==0.6.1
# via azure-storage-blob
Expand Down Expand Up @@ -412,15 +410,15 @@ jupyter-server==2.12.5
# notebook-shim
jupyter-server-terminals==0.5.2
# via jupyter-server
jupyterlab==4.1.0
jupyterlab==4.0.12
# via notebook
jupyterlab-pygments==0.3.0
# via nbconvert
jupyterlab-server==2.25.2
# via
# jupyterlab
# notebook
jupyterlab-widgets==3.0.9
jupyterlab-widgets==3.0.10
# via ipywidgets
kubernetes==20.13.0
# via feast (setup.py)
Expand Down Expand Up @@ -465,7 +463,7 @@ msgpack==1.0.7
# via cachecontrol
multiprocess==0.70.16
# via bytewax
mypy==1.1.1
mypy==1.8.0
# via
# feast (setup.py)
# sqlalchemy
Expand All @@ -489,7 +487,7 @@ nest-asyncio==1.6.0
# via ipykernel
nodeenv==1.8.0
# via pre-commit
notebook==7.0.7
notebook==7.0.8
# via great-expectations
notebook-shim==0.2.3
# via
Expand Down Expand Up @@ -878,7 +876,7 @@ tornado==6.4
# jupyterlab
# notebook
# terminado
tqdm==4.66.1
tqdm==4.66.2
# via
# feast (setup.py)
# great-expectations
Expand Down Expand Up @@ -960,7 +958,7 @@ urllib3==1.26.18
# requests
# responses
# rockset
uvicorn[standard]==0.27.0.post1
uvicorn[standard]==0.27.1
# via
# feast (setup.py)
# uvicorn
Expand Down Expand Up @@ -992,7 +990,7 @@ werkzeug==3.0.1
# via moto
wheel==0.42.0
# via pip-tools
widgetsnbextension==4.0.9
widgetsnbextension==4.0.10
# via ipywidgets
wrapt==1.16.0
# via testcontainers
Expand Down
Loading

0 comments on commit 0f5e838

Please sign in to comment.