Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration-tests: remove users crate #577

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

djach7
Copy link
Contributor

@djach7 djach7 commented Nov 17, 2023

The users crate has been unmaintained for some time. This fix replaces its functionality with terminal commands resulting in the same output, and removes the users crate from the dependencies.

Fixes #566

@djach7 djach7 force-pushed the remove_users_crate branch from d41b931 to 13aa39b Compare November 17, 2023 21:02
@djach7 djach7 marked this pull request as draft November 17, 2023 21:06
Copy link
Contributor

@7flying 7flying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, this removes a dependency and we still have the same functionality that we needed, will approve once you mark the PR as ready.

The users crate has been unmaintained for some time. This fix replaces
its functionality with terminal commands resulting in the same output.
@djach7 djach7 force-pushed the remove_users_crate branch from 13aa39b to 574d4e4 Compare November 27, 2023 15:26
@djach7 djach7 marked this pull request as ready for review November 27, 2023 16:16
Copy link
Contributor

@7flying 7flying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 71624ca into fdo-rs:main Nov 27, 2023
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the users crate with sysinfo
2 participants