Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: examples and howto file #670

Closed
wants to merge 3 commits into from
Closed

fix: examples and howto file #670

wants to merge 3 commits into from

Conversation

EliadCohen
Copy link
Contributor

fix(examples and docs): Changes service info api port from 8089 to 8083 for consistency

Closes: #668

@EliadCohen
fix: Examples and howto file
95d722e 
Changes service info api port from 8089 to 8083 for consistency
nullr0ute
nullr0ute approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@nullr0ute nullr0ute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@nullr0ute
Copy link
Contributor

@EliadCohen could you update the commit to fix the commit lint please?

@EliadCohen
Copy link
Contributor Author

@EliadCohen could you update the commit to fix the commit lint please?

I'm on it

@EliadCohen EliadCohen changed the title fix: Examples and howto file fix: examples and howto file Oct 9, 2024
@nullr0ute
Copy link
Contributor

Pushed as 8bcd8df

@nullr0ute nullr0ute closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nullr0ute nullr0ute nullr0ute approved these changes

@runcom runcom runcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The documentation/example files reference port 8089 and 8083 in the context of service_info_api_url
3 participants
@EliadCohen @nullr0ute @runcom