Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling correction Onborading -> Onboarding #559

Closed
wants to merge 3 commits into from
Closed

Spelling correction Onborading -> Onboarding #559

wants to merge 3 commits into from

Conversation

Bert-R
Copy link
Contributor

@Bert-R Bert-R commented Oct 13, 2023

No description provided.

@nullr0ute
Copy link
Contributor

Hi, there looks like a couple of CI bits inc possibly another spelling error that could be be fixed if y you'd like in this PR, if you could take a look. Thanks.

@7flying
Copy link
Contributor

7flying commented Oct 16, 2023

@Bert-R thanks for your contribution, there are a couple of tests that won't pass (Clippy, build_and_test, Test Devcontainer Creation) due to an open issue that we need to solve first on our end, however, on your end you should update your commit messages so that the commitlint check passes.
We need something with a format like fix: spelling corrections [...], you can see other commits in the repo as an example. Thanks.

@Bert-R Bert-R mentioned this pull request Oct 16, 2023
Merged
@Bert-R
Copy link
Contributor Author

Bert-R commented Oct 16, 2023

Superseded by #561

@Bert-R Bert-R closed this Oct 16, 2023
@Bert-R Bert-R deleted the patch-1 branch October 16, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bert-R @nullr0ute @7flying