-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(howto): removed /var/lib/fdo requisite from serviceinfo-api-server #554
base: main
Are you sure you want to change the base?
Conversation
7d62504
to
f487257
Compare
Fixed the name of the commit |
Having it elsewhere may cause issues with SELinux and from a support PoV I would prefer us to have a default location here. |
@nullr0ute agreed, but the docs are also not completely right about this. We can either explain this better on the docs or enforce the usage of that default location on code. |
I agree. My main concern is clarity for developers who are trying to integrate this service into their environments. If there's potential for issues when deviating from the |
Thank you for the fast response by the way :) |
I don't follow this point about containerisation, the /var/lib directory structure is used for services data for a very long time irrespective of containerisation or not. |
I see your point regarding the |
The
HOWTO.md
document mentions that files parsed through theserviceinfo-api-server
should have theirsource_path
variable located under the/var/lib/fdo
directory. However, during onboarding, the process seems to work correctly even when thesource_path
is set to a different directory. Additionally, the code in serviceinfo-api-server/src/main.rs does not enforce this directory requirement.