Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update aws-nitro-enclaves-cose requirement from 0.4.0 to 0.5.0 #309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2022

Updates the requirements on aws-nitro-enclaves-cose to permit the latest version.

Release notes

Sourced from aws-nitro-enclaves-cose's releases.

Release v0.5.0

  • Support signing with an AWS KMS private key via the key_kms feature. (thank you @​puiterwijk)
  • Abstract Openssl operations (thank you @​raoulstrackx)
  • Update and declare MSRV to 1.58
Changelog

Sourced from aws-nitro-enclaves-cose's changelog.

0.5.0

  • Support signing with an AWS KMS private key via the key_kms feature. (thank you @​puiterwijk)
  • Abstract Openssl operations (thank you @​raoulstrackx)
  • Update and declare MSRV to 1.58

0.4.0

  • Abstract signing support: provide traits to abstract private and public keys.
  • Support signing with a TPM-backed private key via the key_tpm feature.

0.3.0

  • Breaking change: Use upper case acronyms as advised by clippy
  • New Feature: COSE encryption is now available. Thank you @​runcom for the patches.
  • Allow access to CoseSign1 headers, to allow algorithms to use read and set them. Thank you @​puiterwijk.
  • Minor fixes and version bumps.

0.2.0

  • Bump serde_with version.
  • CBOR tags support: can add and verify tags on COSESign1.
  • Use PKey instead of EcKey. Just an interface change, RSA not supported yet. (thanks @​puiterwijk) This will likely change again in the future to support awslabs/aws-nitro-enclaves-cose#5.
  • Implement std::error::Error for COSEError (thanks @​puiterwijk)

0.1.0

Initial Release

Commits
  • b95205c update to v0.5.0
  • b236773 fixup: remove tokio fom dev-dependencies
  • 90ea3cc kms: do not create a new runtime, use a handle
  • fd155ed Rebase and update SDK latest version
  • b8d438a rust: set MSRV to 1.58.1
  • 405e3ed Implement AWS KMS cryptography
  • 44ad72a Address reviewer comments
  • f641e9c Address reviewer comments
  • aa19d8a Fix TPM related compile issues
  • 349e4c6 Version bump
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Aug 9, 2022
@dependabot dependabot bot requested a review from a team August 9, 2022 10:21
@dependabot dependabot bot force-pushed the dependabot/cargo/aws-nitro-enclaves-cose-0.5.0 branch from 0efed57 to 62651a2 Compare October 6, 2022 14:36
@nullr0ute nullr0ute added this to the v0.5.0 milestone Oct 23, 2022
@7flying 7flying removed this from the v0.5.0 milestone Nov 29, 2022
@7flying
Copy link
Contributor

7flying commented Nov 29, 2022

Needs some extra work to handle the API changes on the new version, removing from the v0.5.0 milestone.

@7flying 7flying force-pushed the dependabot/cargo/aws-nitro-enclaves-cose-0.5.0 branch from a116bc1 to a06a3a8 Compare January 2, 2023 13:11
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 12, 2023

A newer version of aws-nitro-enclaves-cose exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot bot and others added 2 commits January 4, 2024 10:33
Updates the requirements on [aws-nitro-enclaves-cose](https://github.com/awslabs/aws-nitro-enclaves-cose) to permit the latest version.
- [Release notes](https://github.com/awslabs/aws-nitro-enclaves-cose/releases)
- [Changelog](https://github.com/awslabs/aws-nitro-enclaves-cose/blob/main/CHANGELOG.md)
- [Commits](awslabs/aws-nitro-enclaves-cose@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: aws-nitro-enclaves-cose
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Irene Diez <[email protected]>
@7flying 7flying force-pushed the dependabot/cargo/aws-nitro-enclaves-cose-0.5.0 branch from cbd8f0e to 6124b7b Compare January 4, 2024 09:37
@nullr0ute
Copy link
Contributor

So seeing this when building in Fedora build system, but not when I run "cargo build" locally on Fediora 26:

   Compiling aws-nitro-enclaves-cose v0.4.0
     Running `/usr/bin/rustc --crate-name aws_nitro_enclaves_cose --edition=2018 /usr/share/cargo/registry/aws-nitro-enclaves-cose-0.4.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=2 --cfg 'feature="default"' --cfg 'feature="key_openssl_pkey"' -C metadata=671ab2e4b20d1870 -C extra-filename=-671ab2e4b20d1870 --out-dir /builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps -L dependency=/builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps --extern openssl=/builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps/libopenssl-51ff0954302018ef.rmeta --extern serde=/builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps/libserde-b1c91f41cca2ed34.rmeta --extern serde_bytes=/builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps/libserde_bytes-902f70f468e423ea.rmeta --extern serde_cbor=/builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps/libserde_cbor-3717611e80ae4bb8.rmeta --extern serde_repr=/builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps/libserde_repr-154d95e8b692db08.so --extern serde_with=/builddir/build/BUILD/fido-device-onboard-rs-0.4.12/target/rpm/deps/libserde_with-791a4c82e78d88f0.rmeta --cap-lints allow -Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Cforce-frame-pointers=yes -Clink-arg=-Wl,-z,relro -Clink-arg=-Wl,-z,now -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes --cap-lints=warn`
error: field must have #[serde(default)] because previous field 2 has #[serde(default)]
   --> /usr/share/cargo/registry/aws-nitro-enclaves-cose-0.4.0/src/sign.rs:138:5
    |
138 |     ByteBuf,
    |     ^^^^^^^
error: field must have #[serde(default)] because previous field 2 has #[serde(default)]
   --> /usr/share/cargo/registry/aws-nitro-enclaves-cose-0.4.0/src/sign.rs:140:5
    |
140 |     ByteBuf,
    |     ^^^^^^^
error[E0277]: the trait bound `SigStructure: encrypt::_::_serde::Serialize` is not satisfied
   --> /usr/share/cargo/registry/aws-nitro-enclaves-cose-0.4.0/src/sign.rs:168:28
    |
168 |         serde_cbor::to_vec(self)
    |         ------------------ ^^^^ the trait `encrypt::_::_serde::Serialize` is not implemented for `SigStructure`
    |         |
    |         required by a bound introduced by this call
    |
    = help: the following other types implement trait `encrypt::_::_serde::Serialize`:
              bool
              char
              isize
              i8
              i16
              i32
              i64
              i128
            and 142 others
note: required by a bound in `to_vec`
   --> /usr/share/cargo/registry/serde_cbor-0.11.2/src/ser.rs:22:8
    |
20  | pub fn to_vec<T>(value: &T) -> Result<Vec<u8>>
    |        ------ required by a bound in this function
21  | where
22  |     T: ser::Serialize,
    |        ^^^^^^^^^^^^^^ required by this bound in `to_vec`
For more information about this error, try `rustc --explain E0277`.
error: could not compile `aws-nitro-enclaves-cose` (lib) due to 3 previous errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants