check the TYPE parameter in a case-insensitive manner (#386)

* check the TYPE parameter in a case-insensitive manner * add some tests
fclairamb · Jan 4, 2023 · 0b1a04e · 0b1a04e
1 parent d33ce00
commit 0b1a04e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/handle_misc.go b/handle_misc.go
@@ -257,6 +257,7 @@ func (c *clientHandler) handleFEAT(param string) error {
 }
 
 func (c *clientHandler) handleTYPE(param string) error {
+	param = strings.ReplaceAll(strings.ToUpper(param), " ", "")
 	switch param {
 	case "I", "L8":
 		c.currentTransferType = TransferTypeBinary

diff --git a/handle_misc_test.go b/handle_misc_test.go
@@ -297,6 +297,22 @@ func TestTYPE(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, StatusOK, rc)
 
+	rc, _, err = raw.SendCommand("TYPE i")
+	require.NoError(t, err)
+	require.Equal(t, StatusOK, rc)
+
+	rc, _, err = raw.SendCommand("TYPE a")
+	require.NoError(t, err)
+	require.Equal(t, StatusOK, rc)
+
+	rc, _, err = raw.SendCommand("TYPE l 8")
+	require.NoError(t, err)
+	require.Equal(t, StatusOK, rc)
+
+	rc, _, err = raw.SendCommand("TYPE l 7")
+	require.NoError(t, err)
+	require.Equal(t, StatusOK, rc)
+
 	rc, _, err = raw.SendCommand("TYPE wrong")
 	require.NoError(t, err)
 	require.Equal(t, StatusNotImplementedParam, rc)