Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offers, priceCurrency and price to RDFa on course detail page/screen; #264

Open
igobranco opened this issue Oct 22, 2024 · 2 comments
Open
Assignees

Comments

@igobranco
Copy link
Member

igobranco commented Oct 22, 2024

Task of: openfun/richie#2451

Related to PR

@Tiago-Salles Tiago-Salles self-assigned this Oct 28, 2024
@Tiago-Salles
Copy link
Contributor

Tiago-Salles commented Nov 14, 2024

Must have for now

  • Add CourseRun additional information to serializer ReactPropsCourseRunSerializer
  • Get currency symbol using priceCurrency
  • Add CourseRun additional information to SyllabusCourseRun
  • Add CourseRun additional information to SyllabusCourseRunCompacted
  • Receive CourseRun information to create or update one
  • Insert the new fields to React CourseRun factory
  • Adjust partially free message to be the same of the free case
  • Remove default offer and make it possible to be null and blank
  • Create conditions to show the prices according to the offers
  • On the admin the management of showing prices information, is done by inserting the values.
  • Add a method on the Course level that returns a json based on offers format considering their CourseRuns for RDFA purposes.
  • Add price fields to the admin tests
  • Apply the CourseRuns RDFA json in the Course page (define the best position to inject this information)
  • In course card add the offer information using icon (check icon), for the free and partially free.

What we won't do for now

  • Add toggle on the admin page to enable or disable these fields
  • In the CTA button with login, change from "Log in to enroll" to "Log in to enroll for free" (Faça login para se inscrever gratuitamente)
  • In the CTA button without login, change from "Enroll now" to "Enroll now for free" (Inscreva-se já gratuitamente)

@Tiago-Salles
Copy link
Contributor

Tiago-Salles commented Nov 18, 2024

Check the need of hide information about the prices if does not exist. It is more clear if shows the information even free.

paid and free

drawing

paid and paid

drawing

partially free

drawing

free and free

drawing

price and null

drawing

null and price

drawing

null and null

drawing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants