Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiple line to additional logos #7

Merged

Conversation

sandroscosta
Copy link

@sandroscosta sandroscosta commented Oct 9, 2024

  • Add a way to create multiple lines on the footer, so that we can mimic the same behaviour that exists on the marketing site

The new setting has be created with the idea of 1 array per line, similar to this example:

MFE_CONFIG["FOOTER_ADDITIONAL_LOGOS"] = '[[{"src": "https://nau-prod-richie-nau-media.rgw.nau.fccn.pt/media/filer_public_thumbnails/filer_public/2a/f5/2af51561-e2cd-4b12-8cbe-c62aca6e1727/barra.png__9851x1422_subsampling-2.png","alt": "PRR Plano de Recuperação e Resiliência, República Portuguesa, Financiado pela União Europeia NextGenerationEU","url": "https://www.fccn.pt/inovacao/projeto-nau-financiamento-sama/"},{"src": "https://nau-prod-richie-nau-media.rgw.nau.fccn.pt/media/filer_public_thumbnails/filer_public/64/a7/64a7c11d-c3f8-4487-95c0-46b3f8bb5236/4logos-feder_fse_nau_v2.png__600x720_subsampling-2.png","alt": "Compete2020, Portugal2020, União Europeia Fundo Europeu de Desenvolvimento Regional","url": "https://www.incode2030.gov.pt/"}], [{"src": "https://nau-prod-richie-nau-media.rgw.nau.fccn.pt/media/filer_public_thumbnails/filer_public/23/93/2393278b-fb7d-4f34-bfef-9bad17a2f71c/pt_preto_horizontal.svg__4563x1167.svg", "alt": "República Portuguesa, Ministério da Educação, Ciência e Inovação.", "url": "https://www.portugal.gov.pt/"}, {"src": "https://nau-prod-richie-nau-media.rgw.nau.fccn.pt/media/filer_public_thumbnails/filer_public/2d/7d/2d7d35ff-5b9b-4d15-83e6-8911a8393dd6/2024_logo-fccn-fct-b-preto.svg__852x190.svg", "alt": "FCCN - Serviços digitais FCT; FCT - Fundação para a Ciência e a Tecnologia", "url": "https://www.fccn.pt/"}]]'

https://github.com/fccn/nau-technical/issues/272

- Add a way to create multiple lines on the footer, so that we can mimic
  the same behaviour that exists on the marketing site
@sandroscosta sandroscosta self-assigned this Oct 9, 2024
@sandroscosta sandroscosta requested a review from igobranco October 9, 2024 16:56
Copy link
Member

@igobranco igobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@igobranco
Copy link
Member

@sandroscosta don't forgot to create a new release.

@sandroscosta sandroscosta merged commit 3dcd5e8 into nau/redwood.master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants