Modal TOS on MFE didn't include PT translations #16
Assignees
Comments
igobranco
added a commit
to fccn/openedx-translations
that referenced
this issue
Dec 4, 2024
The forked NAU version of frontend-component-footer was missing the translations of pt_PT and pt locales for the new strings that the forked version includes. fccn/frontend-component-footer-nau#16
|
We need to review those texts. |
igobranco
added a commit
to fccn/openedx-translations
that referenced
this issue
Dec 6, 2024
The modal TOS needs to have translations on a specific way to comply with GDPR. fccn/frontend-component-footer-nau#16
igobranco
added a commit
to fccn/openedx-translations
that referenced
this issue
Dec 6, 2024
The modal TOS needs to have translations on a specific way to comply with GDPR. fccn/frontend-component-footer-nau#16 fccn/nau-technical#367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to: https://github.com/fccn/nau-technical/issues/87
Problem:
Modal TOS on MFE didn't include PT translations.
Screenshot:
During MFE build, each MFE pulls translations for the frontend-component-footer and also for it self.
https://github.com/openedx/frontend-app-learning/blob/master/Makefile#L45C70-L45C96
When Atlas was introduced, the pull of translations is from a specific translations git repo.
The openedx-translations repo didn't include the new translations for our forked footer.
https://github.com/fccn/frontend-component-footer-nau/blob/nau/redwood.master/src/i18n/messages/pt_PT.json
We need to manually include the modalTOS translations on the pt_PT.json file on the https://github.com/fccn/openedx-translations/blob/nau/redwood.master/translations/frontend-component-footer/src/i18n/messages/pt_PT.json so when openedx atlas downloads the translations, it will include those new translations.
The text was updated successfully, but these errors were encountered: