-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.backend.{name} in toml always create backend with overide_host set as the address #1268
Comments
Have you tried removing the setting in the management console after the fact? In my experience, this makes the backend stop functioning, so setting this value seems necessary. |
In many cases, getting |
By the way, local_server has a functional override_host field (with or without the setting makes a difference).
|
The platform doesn't allow this, unless your code registers a dynamic backend. The override host field is not the correct place to allow this feature. |
When making a static backend in the UI, this is exactly how it works, the platform allows it, override_host was added as a way to improve this for users because many users wanted to set the host header value in the backend definition rather than in their code. We've since come to a place where we are inconsistent in what we do by default for users. The UI will not add override host by default, but the cli will. |
I thought it was the opposite, but I could be mistaken. |
Not only cli will (add override host by default), there is no way to let cli to not do it |
Indeed, the current data model for |
Well, the fix won't be quick as it will require extensive work in the test suite for the |
In toml, get below setup, notice that there is no setting field
override_host
.After running
fastly compute publish
We get a service with a backend that has "override host" set to
example.org
Currently, there is no way to set up a backend with an empty "override host"
The text was updated successfully, but these errors were encountered: