Wrong number of arguments with v2.0.0

[felginep]

With the new version 2.0.0, the method upload_file expects 9 arguments but is called with only 7.

In version 1.8.3

fastlane-plugin-s3/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb

Line 503 in 20ae0fe

def self.upload_file(s3_client, bucket_name, app_directory, file_name, file_data, acl, server_side_encryption)

In version 2.0.0

fastlane-plugin-s3/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb

Line 559 in b2a05da

def self.upload_file(s3_client, bucket_name, app_directory, file_name, file_data, acl, server_side_encryption, download_endpoint, download_endpoint_replacement_regex)

The call site does not change and still pass only 7 arguments:

fastlane-plugin-s3/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb

Line 529 in b2a05da

file_url = self.upload_file(s3_client, s3_bucket, app_directory, file_name, file_data, acl, server_side_encryption)

Here is a callstack

ArgumentError: [!] wrong number of arguments (given 7, expected 9)
  .../fastlane-plugin-aws_s3-2.0.0/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb:559:in `upload_file'
  .../fastlane-plugin-aws_s3-2.0.0/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb:529:in `block in upload_files'
  .../fastlane-plugin-aws_s3-2.0.0/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb:524:in `each'
  .../fastlane-plugin-aws_s3-2.0.0/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb:524:in `upload_files'
  .../fastlane-plugin-aws_s3-2.0.0/lib/fastlane/plugin/aws_s3/actions/aws_s3_action.rb:103:in `run'
  .../fastlane-2.178.0/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
  .../fastlane-2.178.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
  .../fastlane-2.178.0/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
  .../fastlane-2.178.0/fastlane/lib/fastlane/runner.rb:229:in `chdir'
  .../fastlane-2.178.0/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
  .../fastlane-2.178.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
  .../fastlane-2.178.0/fastlane/lib/fastlane/other_action.rb:23:in `method_missing'

[schwmi]

Have the same error - I am calling aws_s3 via:

        aws_s3(
              bucket: "…",
              region: "…",
              files: [".zip"],
              app_directory: "…"
        )

using it it distribute a zipped Mac app. This used to work in previous versions.

[joshdholtz]

Ah sorry! Will fix will fix