Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unescape url before gsub #95

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Unescape url before gsub #95

merged 1 commit into from
Mar 25, 2021

Conversation

felginep
Copy link
Contributor

Fix #94

We escape the url before doing a gsub. That way, if the file name contains characters that have been encoded during the upload, the gsub will not fail.

joshdholtz
joshdholtz approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you so much for the contribution ❤️

@joshdholtz joshdholtz merged commit 003ab10 into fastlane-community:master Mar 25, 2021
@felginep felginep deleted the feature/fix_s3_folder_output_path branch March 25, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Value of S3_FOLDER_OUTPUT_PATH is sometimes wrong due to url encoding
2 participants
@felginep @joshdholtz