Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no implicit conversion of nil into String #58

Closed
acecilia opened this issue Apr 24, 2018 · 3 comments
Closed

no implicit conversion of nil into String #58

acecilia opened this issue Apr 24, 2018 · 3 comments

Comments

@acecilia
Copy link

Updated to 1.4.0 from 1.1.1, I am getting the error "no implicit conversion of nil into String" in the aws_s3 fastlane step.

I can not provide much more information, since I can not see any more logs in the terminal. For now, I reverted back to version 1.1.1.

@katunch
Copy link

katunch commented Apr 26, 2018

You have to set the CFBundleDisplayName in you Info.plist.
See -> Issue #46

@katunch
Copy link

katunch commented Apr 26, 2018

The perfect solving this issue is to use CFBundleDisplayName only when it is available. Otherwise use CFBundleName.

@acecilia
Copy link
Author

acecilia commented Apr 26, 2018

@katunch you mean that to resolve the issue the code in here will need to be changed to use CFBundleDisplayName, or CFBundleName in case CFBundleDisplayName is not available?

At the moment I am using fastlane, so the Info.plist file is managed automatically by the lane.

EDIT: I confirm that changing CFBundleName to CFBundleDisplayName in Info.plist fixes the issue, and seems like CFBundleDisplayName is a required key, and CFBundleName just recommended (see this), so the change seems to makes sense (I hope it does not break anything! ;P)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants