Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android APK HTML app title showing up as "0x0" #116

Closed
machty opened this issue May 15, 2023 · 1 comment
Closed

Android APK HTML app title showing up as "0x0" #116

machty opened this issue May 15, 2023 · 1 comment

Comments

@machty
Copy link

machty commented May 15, 2023

I'm guessing this is due to devunwired/apktools#14

My AndroidManifest.xml has <application ... android:label="@string/app_name"> and fastlane-plugin-s3 seems to use label attributes to determine the app title to put in the download HTML for Android, but the string name it resolves is "0x0" producing a download page that looks like:

image

Am I doing something weird by using a resource value reference instead of a hardwired name? Is there a way around this?

@machty
Copy link
Author

machty commented May 19, 2023

This is easy enough to resolve by fetching the title within Fastfile and passing the following args to aws_s3(...)

html_template_params: {
      title: "my title",
},

@machty machty closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant