Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: acl options should be hyphenated not underscored #109

Merged
merged 1 commit into from
Mar 5, 2022
Merged

docs: acl options should be hyphenated not underscored #109

merged 1 commit into from
Mar 5, 2022

Conversation

tfaieta
Copy link
Contributor

@tfaieta tfaieta commented Feb 24, 2022

Fixes #108, if I did anything wrong let me know! Thanks again for everything you all do for fastlane! 😄

docs: acl options should be hyphenated not underscored

  • public_read -> public-read
  • public_read_write -> public-read-write
  • authenticated_read -> authenticated-read

@tfaieta
docs: acl options should be hyphenated not underscored
5e85c02 
---
- public_read -> public-read
- public_read_write -> public-read-write
- authenticated_read -> authenticated-read
joshdholtz
joshdholtz approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, thank you for catching and fixing this! 🙌

@joshdholtz joshdholtz merged commit c942545 into fastlane-community:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

acl options should be hyphenated not underscored
2 participants
@tfaieta @joshdholtz