Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl options should be hyphenated not underscored #108

Closed
tfaieta opened this issue Feb 24, 2022 · 0 comments · Fixed by #109
Closed

acl options should be hyphenated not underscored #108

tfaieta opened this issue Feb 24, 2022 · 0 comments · Fixed by #109

Comments

@tfaieta
Copy link
Contributor

tfaieta commented Feb 24, 2022

Hey thanks for everything you all do with fastlane, really love the project 😄 🍾 . Noticed one small issue in the documentation for the acl option:

description: "Uploaded object permissions e.g public_read (default), private, public_read_write, authenticated_read ",

I believe the correct options are hyphenated public-read (like the default is), public-read-write, and authenticated-read instead of the underscored documented above.

AWS docs: https://docs.aws.amazon.com/cli/latest/reference/s3api/put-object.html#options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant