Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reuse" SharedValues for APK and IPA path #17

Open
janpio opened this issue Oct 19, 2017 · 1 comment
Open

"Reuse" SharedValues for APK and IPA path #17

janpio opened this issue Oct 19, 2017 · 1 comment
Labels
Milestone

Comments

@janpio
Copy link
Collaborator

janpio commented Oct 19, 2017

Actions like hockey are using SharedValues::GRADLE_APK_OUTPUT_PATH or SharedValues::IPA_OUTPUT_PATH so you don't have to explicitly set the APK path:

https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/hockey.rb#L185
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/hockey.rb#L204

This plugin could also set these values when a build succeeded additionally to its own variables so hockey and similar actions also don't need to manually get the path.

@janpio janpio added the Backlog label Oct 19, 2017
@janpio
Copy link
Collaborator Author

janpio commented Oct 19, 2017

When #8 is implemented, this can also be done for https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/hockey.rb#L216

@janpio janpio added this to the 0.0.3 milestone Oct 20, 2017
@janpio janpio added todo and removed Backlog labels Oct 24, 2017
@janpio janpio modified the milestones: 0.0.3, 0.0.4 Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant