Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependence on type param for iOS builds #13

Open
janpio opened this issue Oct 19, 2017 · 4 comments
Open

Clean up dependence on type param for iOS builds #13

janpio opened this issue Oct 19, 2017 · 4 comments
Labels
Milestone

Comments

@janpio
Copy link
Collaborator

janpio commented Oct 19, 2017

iOS builds are dependant on the type param right now as they are used to get the correct certificate for a build:

https://github.com/ionic-zone/fastlane-plugin-ionic/blob/master/lib/fastlane/plugin/ionic/actions/ionic_action.rb#L52

@janpio janpio added the Backlog label Oct 19, 2017
@janpio
Copy link
Collaborator Author

janpio commented Oct 19, 2017

This is related to #12

Because of this right now one has to build for development this way right now:

    match
    ionic(
      platform: 'ios',
      release: false,
      type: 'development'
   )

@janpio
Copy link
Collaborator Author

janpio commented Oct 19, 2017

Possible solution:

If release == false => type = development || param[:type]
When build with --debug, set type to development or any supplied value

@janpio janpio added todo and removed Backlog labels Oct 19, 2017
@janpio
Copy link
Collaborator Author

janpio commented Oct 19, 2017

More thoughts:

Official documentation of the packageType param this fills:

-- -- --
Packaging Type --packageType This will determine what type of build is generated by Xcode. Valid options are development (the default), enterprise, ad-hoc, and app-store.

release can be true or false for the plugin (which corresponds to --release and --debug on the CLI).

Default value right now is app-store: https://github.com/ionic-zone/fastlane-plugin-ionic/blob/master/lib/fastlane/plugin/ionic/actions/ionic_action.rb#L173

So it would make sense to do this:
release:true -> app-store
release:false -> development

@janpio
Copy link
Collaborator Author

janpio commented Oct 19, 2017

Documentation of https://github.com/ionic-zone/fastlane-plugin-ionic/blob/master/lib/fastlane/plugin/ionic/actions/ionic_action.rb#L171 should be made clearer as well an mention that it also defines which certificate is used to build.

@janpio janpio added this to the 0.0.3 milestone Oct 24, 2017
@janpio janpio modified the milestones: 0.0.3, 0.0.4 Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant