New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential upgrades for lyrics #4652

Open

OrangeZXZ opened this issue Nov 26, 2024 · 0 comments

Labels

OrangeZXZ commented Nov 26, 2024

Description

When using the lyrics, I had one problem : when we have skip to lyric option turned off, we still can press the lyrics (and I use press to show and close lyrics)

Suggested Solution

My C# teacher always said "If it c'ant be visible or touched by the user, then it is disabled".
Explanation : If we disable the text collision, instead of the action done by it being pressed, we could press anywhere to close the lyrics

Alternatives

I think that the collision could also have the same size as the text, that way we can press on the corners to close.

Also a "X" button could be present at the top left to easily close it without the button if it is disabled.

Additional Context

No response

OrangeZXZ added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment