Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mass_breakdown_sun_plot when using low rtol solver values #542

Open
enricostragiotti opened this issue Jul 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@enricostragiotti
Copy link
Contributor

Describe the bug
The plotting function mass_breakdown_sun_plot produces a single plot (only the OWE breakdown) if MTOW != OWE + payload + onboard_fuel_at_takeoff.

See image:
image

To Reproduce
When solving a simple MDA specifying a low acceptable rtol e.g. nonlinear_solver: om.NonlinearBlockGS(maxiter=100, rtol=1e-2) it can happen that MTOW != OWE + payload + onboard_fuel_at_takeoff. In those cases the following test

if round(mtow, 6) == round(owe + payload + onboard_fuel_at_takeoff, 6):
mtow = owe + payload + onboard_fuel_at_takeoff

is not passed and the image is not generated.

Expected behavior
A user feedback explaining what is happening could be beneficial, as "The MTOW breakdown is not plotted as MTOW / (OWE + payload + onboard_fuel_at_takeoff) is higher than ... Try to re-run the MDA with a lower solver rtol value."

Environment

  • Operating System: Windows 10
  • Python environment: Python 3.9.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant