Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Festival - followers rule #433

Open
stanolacko opened this issue Aug 18, 2022 · 2 comments
Open

Festival - followers rule #433

stanolacko opened this issue Aug 18, 2022 · 2 comments

Comments

@stanolacko
Copy link
Contributor

When plaing Festival and followers rule set for festival,
festival tile dosn't allow to return any meeple.
By rule it has to be not followers but figures and it has to allow return any of player's figure.

@stanolacko
Copy link
Contributor Author

Checked codes and FestivalCapability and it working as designed.
Problem is in Client. Barn in MeepleLayer doesn't have selectable circle defined.
Plus it's important to rename options for rule in client to use names used in rules
Meeple = Follower = Small Meeple, Large Meeple, Mayor, Wagon, Ringmaster, Phantom
Special figure = Builder, Pig, Barn, Shephers.

So current "meeple" rule has to be "figure"
and current "follower" rule has to be "meeple".

@farin Do I create Issue on Client or I'll keep it onle here (because, issue is related to client, not with Engine).

@stanolacko
Copy link
Contributor Author

Ok. There is bug in client:
if ("follower".equals(state.getStringRule(Rule.FESTIVAL_RETURN))) { meeples = meeples.filter(Predicates.instanceOf(Follower.class)); }
It has to be "followers".

Or update Client with correct names and use value "follower" instead of "followers" for rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant