Skip to content
This repository has been archived by the owner on Jun 28, 2020. It is now read-only.

[Feature Request] Add Image URL in Pokemon.json #15

Open
Purukitto opened this issue Aug 16, 2019 · 8 comments
Open

[Feature Request] Add Image URL in Pokemon.json #15

Purukitto opened this issue Aug 16, 2019 · 8 comments

Comments

@Purukitto
Copy link
Contributor

Makes it easier to implement

fanzeyi pushed a commit that referenced this issue Aug 21, 2019
* Rename Image Files ( For easier access ) #15

* #15

* #15 Thumbnail names also changed
@fanzeyi
Copy link
Owner

fanzeyi commented Aug 21, 2019

I believe this should be addressed in your PR #16?

@fanzeyi fanzeyi closed this as completed Aug 21, 2019
@Purukitto
Copy link
Contributor Author

@fanzeyi No I had only change the file names in that PR. I am working on the commit with all the URL in the JSON.

@Purukitto
Copy link
Contributor Author

Will push this in the next PR

@Purukitto
Copy link
Contributor Author

Does the "MS" at the end of every sprite image has any purpose? Or may I remove it ? It would be easier to add the URLs without having to append MS

@fanzeyi fanzeyi reopened this Aug 25, 2019
@fanzeyi
Copy link
Owner

fanzeyi commented Aug 25, 2019

@Purukitto AFAIK no. I'm not sure why it is there in the first place. Feel free to remove it.

@Purukitto
Copy link
Contributor Author

Purukitto commented Aug 25, 2019

I'm not sure why it is there in the first place. Feel free to remove it.

Will do

@PolygonPapillon
Copy link

I believe the MS stands for "mini sprite". If the MS was removed there would be no difference between the names of the images in the 'image' file and the 'sprites' file.

@fanzeyi
Copy link
Owner

fanzeyi commented Dec 1, 2019

@PolygonPapillon Ah! Thanks for the explanation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants